Skip to content

fix: Handle transposed flow cell format in Biacore Insight parser#1199

Merged
nathan-stender merged 1 commit into
mainfrom
fix/biacore-insight-run-name-detection
May 18, 2026
Merged

fix: Handle transposed flow cell format in Biacore Insight parser#1199
nathan-stender merged 1 commit into
mainfrom
fix/biacore-insight-run-name-detection

Conversation

@nathan-stender

@nathan-stender nathan-stender commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fixes false-positive "multiple runs" error for files from Biacore Insight Evaluation v3.0.12+ which use a transposed "Flow cell N" layout in the Properties sheet
  • The run-detection predicate startswith("Run") was matching "Run name" attribute rows within flow cell sections — tightened to regex Run \d+$
  • Added logic to transpose the newer "Flow cell N" row-based sections into the flat tabular format the downstream code expects

Context

Files with v3.0.12+ triggered:

"Instrument file contains multiple runs. Only single runs are supported at the moment."

The file actually contained a single run — the error was caused by "Run name" rows in the Properties sheet falsely matching the run-splitting logic.

Test plan

  • Existing 4 test cases pass unchanged
  • New anonymized test file (Biacore_Insight_Transposed_FlowCells.xlsx) covers the transposed format
  • Vendor discovery tests pass
  • Linting passes

🤖 Generated with Claude Code

… sheet

Files from newer Biacore Insight Evaluation software (v3.0.12+) use a
transposed layout where flow cell data appears as "Flow cell N" row
sections instead of a flat columnar table. The "Run name" attribute
within these sections falsely matched the run-detection predicate
`startswith("Run")`, causing a spurious "multiple runs" error.

Tighten the run-header regex to only match "Run \d+" and add logic to
transpose the new "Flow cell N" sections into the tabular format the
downstream code expects.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nathan-stender
nathan-stender requested review from a team and slopez-b as code owners May 18, 2026 18:50
@nathan-stender
nathan-stender requested a review from tamargrey May 18, 2026 18:50
@nathan-stender
nathan-stender merged commit 7f4c250 into main May 18, 2026
16 checks passed
@nathan-stender
nathan-stender deleted the fix/biacore-insight-run-name-detection branch May 18, 2026 19:57
nathan-stender added a commit that referenced this pull request May 19, 2026
### Added

- Add Claude skill for generating Allotropy parsers (#1160)

### Fixed

- Support bare UV curve name in Cytiva Unicorn parser (#1200)
- Handle transposed flow cell format in Biacore Insight parser (#1199)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants